search

tomusdrw / rust-web3

Ethereum JSON-RPC multi-transport client. Rust implementation of web3 library. ENS address: rust-web3.eth
MIT License
1.45k stars 471 forks source link

Ethereum Name Service #562

Closed SionoiS closed 2 years ago

SionoiS commented 3 years ago

Please advise on error handling and test cases.

SionoiS commented 3 years ago

I changed the organisation and added missing functions even those without info and added links to contracts.

Let me know what you think!

Tests, example and docs will have to wait a bit. I received a grant but work start next year.

SionoiS commented 2 years ago

A per ens/mod.rs the only type accessible is ENS.

@tomusdrw most of the documentation your asking for is not user facing. Are you sure? More docs is better I get it.

tomusdrw commented 2 years ago

@tomusdrw most of the documentation your asking for is not user facing. Are you sure? More docs is better I get it.

Correct, internal documentation is useful as well and I think we should put a bit of attention and effort there. Also from my experience it happens rather frequently that things that initially were not public end up being used at some point, so we can already be prepared for this :)