search

tomusdrw / rust-web3

Ethereum JSON-RPC multi-transport client. Rust implementation of web3 library. ENS address: rust-web3.eth
MIT License
1.45k stars 471 forks source link

eth_getProof balance and nonce to U256 #572

Closed lightyear15 closed 2 years ago

lightyear15 commented 2 years ago

after some real-world testing, we figured balance as well as nonce fields might reach the upper limit of U64. Moving these fields to U256

lightyear15 commented 2 years ago

sorry about this :disappointed: should have then more tests before my first PR

tomusdrw commented 2 years ago

No worries! Could you please add a testcase for these large values as well?

lightyear15 commented 2 years ago

Hi @tomusdrw I changed the unit test as you requested. The proof does not need to be consistent as that is not the purpose of the test. So I just changed the value of balance and nonce fields to make them more similar to a real-case.

tomusdrw commented 2 years ago

Perfect, thank you!