search

tomv564 / pyls-mypy

Mypy plugin for the Python Language Server
MIT License
110 stars 62 forks source link

Add a new configuration option 'config_files' #23

Closed hetmankp closed 1 year ago

hetmankp commented 5 years ago

This new configuration option allows us to specify one or more configuration files to be used with mypy. Because of how mypy works, only the first found file will be passed to mypy.

Hi-Angel commented 3 years ago

While on it, you also got an excess commit Merge remote-tracking branch 'upstream/master'.

hetmankp commented 3 years ago

While on it, you also got an excess commit Merge remote-tracking branch 'upstream/master'.

@Hi-Angel , I needed to merge from the upstream to keep my own repository up to date. I thought normally upstream maintainers squashed the whole pull request when they merged the commit anyway though if it's different on this project I'd be happy to rework the commit history.

Happy to clean things up further if there's any interest in actually merging this feature.

Hi-Angel commented 3 years ago

Happy to clean things up further if there's any interest in actually merging this feature.

Sorry, I must mention, I'm in no way affiliated with this project. I was just interested in the feature you added here, and did a little of review while at it. I have a feeling the project is unmaintained :c

@Hi-Angel , I needed to merge from the upstream to keep my own repository up to date. I thought normally upstream maintainers squashed the whole pull request when they merged the commit anyway though if it's different on this project I'd be happy to rework the commit history.

I don't know about this project specifically, but what usually people do is rebase. That is, you do for example git rebase upstream/master (or just press a button rebase on a PR/MR), and the code will be rebased without any unnecessary commits appearing.

Hi-Angel commented 3 years ago

I don't know about this project specifically, but what usually people do is rebase

I must probably elaborate on this. A pull/merge request often has more than one commit "real" commits, i.e. not the "merge" ones. In such case a maintainer can't squash the request, because they'd lose the commit history.

But in your case this may be irrelevant, because you have just one "real" commit, so, you might be right here.

Hi-Angel commented 3 years ago

Sorry btw, I should say I can't close an opened code discussion, because apparently I chosen the wrong option while sending a review. I got used to GItlab UI, which allows to turn any comment to a discussion, and later close it. Lack of such ability in Github is a nuance I didn't know. Oh, well.

Anyway, I just wanted to say that this discussion might be of interest to you.