search

tomvanzummeren / TZStackView

UIStackView replica for iOS 7.x and iOS 8.x
MIT License
1.15k stars 128 forks source link

Add support for tvOS #48

Open nuudles opened 8 years ago

nuudles commented 8 years ago

I needed a UIStackView in some shared code between my tvOS app and an iOS app, so I've gone ahead and added tvOS podspec support for TZStackView and it seems to work great.

iGranDav commented 8 years ago

@tomvanzummeren is there any reason for not merging this PR?

tomvanzummeren commented 8 years ago

Not really, other than I have no time right now to process the whole list of merge requests for TZStackView and release a new cocoapods version etc.

iGranDav commented 8 years ago

Ok do not hesitate to provide contributor rights if you need help to maintain and test this great library.

tomvanzummeren commented 8 years ago

Hey @iGranDav , would you really like to help me maintain this library? I can give you contributor rights if you're still interested!

iGranDav commented 8 years ago

Hello @tomvanzummeren I would be happy to test and merge some PR but I have strongly limited ressources to test under iOS 7

tomvanzummeren commented 8 years ago

@iGranDav well, thanks to one of the pull requests I merged in the past, the library is no longer compatible with iOS 7 anyway. So you would not be making things worse.

But isn't iOS 7 available anymore as a Simulator?

iGranDav commented 8 years ago

@tomvanzummeren not really supported officially and you need to have Xcode 6.4. But in any case it doesn't work that way because you will be then building under SDK 8. And we want to test on iOS 7 with a SDK 9 build.

tomvanzummeren commented 8 years ago

@iGranDav ok I agree, so it won't be a 100% covering test if you test with SDK 8. But it will be a lot better than NOT doing any testing, right?

Best case scenario: you end up restoring iOS 7 support Worst case scenario: everything stays the same (no support for iOS 7)

Are you up for it?

iGranDav commented 8 years ago

Let's do this :+1:

tomvanzummeren commented 8 years ago

I made you a collaborator!

iGranDav commented 8 years ago

Thanks! I'll be merging this tested one first :)

tomvanzummeren commented 8 years ago

aight! good luck!