search

tomwalder / php-gds

Google Cloud Datastore Library for PHP
Apache License 2.0
164 stars 44 forks source link

gRPC Support #172

Closed iamacarpet closed 4 years ago

iamacarpet commented 5 years ago

Hello @tomwalder ,

Here is the gRPC Support for the Second Generation runtime on App Engine.

Still waiting on the merge of the Datastore classes into google-cloud-php, so it references our own build for now.

Regards, iamacarpet

iamacarpet commented 5 years ago

Looks like Travis is failing due to my datastore-grpc not being a stable dependency.

Will wait until it's released in google-cloud-php to fix, but we are running this in production and it is working, minus the composer issue installing it, if anyone is interested.

tomwalder commented 5 years ago

Thanks for this - I'd be keen to merge in when we know it's good to go.

Can you link to your PR for google-cloud-php ?

iamacarpet commented 5 years ago

Sure, it is one from Google themselves:

https://github.com/googleapis/google-cloud-php/pull/1429

Been open a while and still haven't been reviewed, even though they did it themselves.

iamacarpet commented 5 years ago

@tomwalder Google have released their changes for the official google-cloud-php library, so this is ready to go.

It has been deployed on our production app for a few hours and looks good so far.

tomwalder commented 4 years ago

@iamacarpet FYI - this branch is being merged and updated a little around the Firestore move from Google. Thanks again for your hard work so far!