tomyam1 / protractor-video-reporter

Jasmine reporter that captures a screencast of Protractor specs running on a headless browser, e.g. in CI server

MIT License

21 stars 21 forks source link

#14 - All specs video path #18

Open jsgervais opened 7 years ago

jsgervais commented 7 years ago

14 - Allow specifying other name than protractor-specs.mov in case, when one video file is produced.

Added a new option called allSpecsVideoName which can be either a string or a function. It is combined with the baseDirectory option to create a full path.

tomyam1 commented 7 years ago

Hi Jean Thanks for PR! Some issues before this can be merged:

There are some linting issues in the new code, e.g. space in if ( typeof....
Add validation for the options "You must also define baseDirectory path" - this should be validated with JOI.
allSpecsVideoName should be changed to allSpecsVideoPath for consistency with singleVideoPath.
Please don't change the version yet. I'll update it in a separate commit.

I think that's it.

yeikel commented 6 years ago

@tomyam1 Is this PR dead? Last activity was way back