search

tomyam1 / protractor-video-reporter

Jasmine reporter that captures a screencast of Protractor specs running on a headless browser, e.g. in CI server
MIT License
21 stars 21 forks source link

improve singleVideos mode #9

Closed valburyakov closed 7 years ago

valburyakov commented 7 years ago
tomyam1 commented 7 years ago

Hey @valburyakov Thanks for your time. There are several issues I think should be handled before this PR can be merged.

This PR should be separated to two PRs: one for not deleting files on skipped specs and one for changing changing the name of the files.

For the first PR I would use jasmine to detect whether the spec was skipped or not. I don't want to test whether the file exists. If the test was not skipped than the file is expected to exist (and if it doesn't I do want an exception to be thrown). If the test was skipped than the file should not exists and we should not delete it.

For the second PR there are some corner cases that should be handled, e.g. making sure the filename is a valid filename.

tomyam1 commented 7 years ago

Closed since these issues are resolved in 0.3.0