search

tomykaira / rspec-parameterized

RSpec::Parameterized supports simple parameterized test syntax in rspec.
MIT License
417 stars 28 forks source link

use binding_of_caller for JRuby #50

Closed malcolm-pro closed 5 years ago

malcolm-pro commented 5 years ago

for issue #49

sue445 commented 5 years ago

Add jruby to .travis.yml

c.f. https://docs.travis-ci.com/user/languages/ruby/#specifying-ruby-versions-and-implementations

malcolm-pro commented 5 years ago

I guess this is a little more in depth; there is some code that explicitly references the BindingNinja constant. I wonder if it would be worth refactoring that library to give it API-parity with binding_of_caller.

sue445 commented 5 years ago

@mmcfarland-cavulus I think there are 2 patterns.

  1. Add jruby supports to binding_ninja. (maybe this is hard)
  2. Add wrapper (or monkey patch) to rspec-parameterized for hide the difference between binding_ninja and binding_of_caller

@joker1007 Do you think which is better?

joker1007 commented 5 years ago

2 is better. I think so. I guess that I can implement a code branching for binding_of_caller at table_syntax.rb

joker1007 commented 5 years ago

binding_ninja will support jruby soon.

joker1007 commented 5 years ago

I have already released v0.4.2 that is supported JRuby.