ton-blockchain / multisig-contract-v2

Multiowner wallet
54 stars 19 forks source link

Tests run successfully if you change the code #17

Closed isopen closed 6 months ago

isopen commented 6 months ago
  1. Change code image
  2. Rebuild all modules using npx blueprint build
  3. npx blueprint test image It's ok.

Apparently the code is poorly tested and not all validators are checked by autotests.

The vulnerability of the smart contract is as follows:

  1. @tolya-yanot typed some more code
  2. Added a validator and it seems to be ok
  3. Run autotests. Autotests answered “Everything is fine. It's ok”
  4. Product release
  5. Then, like in mint notcoin, there is a floating boost and you will need to disable the smart-contract
  6. Next, the user begins to resent the commissions for unsuccessful transactions that are lost forever

eg: image Long before this change it worked without =

Solution: Write code through autotests.

tolya-yanot commented 6 months ago

offtopic, ban