ton-blockchain / multisig-contract-v2

Multiowner wallet
54 stars 19 forks source link

Order can be approved and executed after time is expired #38

Closed SubFactorial closed 6 months ago

SubFactorial commented 6 months ago

According to requirements: "Each Order has expiration date after which it can not be executed." In case when order is initialized second time and approved at the same time (order.func lines: 210-225) there is no check: throw_unless(error::expired, expiration_date >= now()); Possible solution: add check that time is not expired before approving order in order.func line 224.

tolya-yanot commented 6 months ago

There is expiration_date check in multisig op::execute handler.

No checks on order approve because this is a way to return Toncoin balance of expired order to multisig.