According to requirements: "Each Order has expiration date after which it can not be executed."
In case when order is initialized second time and approved at the same time (order.func lines: 210-225) there is no check:
throw_unless(error::expired, expiration_date >= now());
Possible solution: add check that time is not expired before approving order in order.func line 224.
According to requirements: "Each Order has expiration date after which it can not be executed." In case when order is initialized second time and approved at the same time (order.func lines: 210-225) there is no check: throw_unless(error::expired, expiration_date >= now()); Possible solution: add check that time is not expired before approving order in order.func line 224.