fix: split stake in 2 when not elected / ValidatorList in testnet

redref commented 1 month ago

Not tested in mainnet yes, but if you can confirm this a right solution, I could.

yungwine commented 1 month ago

Can you describe a bug that you're trying to fix?

redref commented 1 month ago

Can you describe a bug that you're trying to fix?

Sure. FTR, this was in testnet.

Run mytoncore
First election on single nominator pool send (pool balance / 2) as expected to elector
Stake is too low => not elected
During the stake period, amount is recovered
Next election, as temporary validation key is present on validator, election send (pool balance) to elector, but behavior should be the same as the first election

This check temporary key is in active period and we are not an active validator to check validator was not elected, which avoids a different behavior. We could argue it gives better chance to be elected in second iteration, but in my POV, if we want to solve this issue, it would be best solved otherwise.

For testnet, I had to fix GetValidatorsList() which does not work properly (checkloadall returns nothing or raise an error, but I think that's expected).

redref commented 2 weeks ago

Any news ?

ton-blockchain / mytonctrl