ton-blockchain / wallet-ios

Standard wallet for iOS
GNU General Public License v2.0
83 stars 45 forks source link

Unlimited passcode trials #13

Closed zmxv closed 2 years ago

zmxv commented 2 years ago

Bug Type

Security

Reproduction steps

  1. Set up a wallet and a four digit passcode.
  2. Restart the wallet app and start entering wrong passcodes.

Actual result

A user can try passcodes as many times as possible.

IMG_8454

Expected result

Rate limiting (with exponential backoff) should be enforced to prevent brute force attack. And passcode should not be limited to four digits only.

Suggested Severity

High

Device

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional Context

No response

menschee commented 2 years ago

Hi! This repo is intended for TON wallet app, not for Tonkeeper. If you have found any bugs with Tonkeeper app, please, open an issue in this repository

zmxv commented 2 years ago

Thanks for the pointer.