ton-society / grants-and-bounties

TON Foundation invites talent to imagine and realize projects that have the potential to integrate with the daily lives of users.
https://ton.org/grants
309 stars 137 forks source link

MyTonWallet added support for TON Connect 2.0 #149

Closed mytonwalletorg closed 1 year ago

mytonwalletorg commented 1 year ago

Name

MyTonWallet

Telegram Contact

@unexpectedusername

Link to demo

https://github.com/ton-connect/wallets-list/pull/11

Amount

5,000 USD in TON

Reward

Total: $5000

delovoyhomie commented 1 year ago

Hey, @mytonwalletorg, can I kindly ask you to submit the PR to follow the official procedure for paying out grants?

Please do not hesitate to ask for any assistance — I’m available at your convinience, should anything bother you at all.

stels-cs commented 1 year ago

You did not support the SendTransaction method. Here is a link to the source code in your repository. This is not even a mistake, but a attempt to deceive the community.

image

https://github.com/mytonwalletorg/mytonwallet/blob/964d5f7b174f46fc021e6b200ae5bc3d5ed23423/src/api/tonConnect/index.ts#L199-L202

Hiyorimi commented 1 year ago

Since @mytonwalletorg hadn't submit request for paying out the grant yet, maybe there are planning to improve the quality of integration and to submit application for paying it up later.

mytonwalletorg commented 1 year ago

The multi-transaction feature is now added in the latest MyTonWallet version (v1.11.10).

Send (2-4)

Obviously, we never tried to deceive the community in any way. We implied that that feature was experimental as even core libraries had not supported it at that time (TonWeb supported it two days ago).

mytonwalletorg commented 1 year ago

158

delovoyhomie commented 1 year ago

There is a problem connecting the wallet with STON.fi. This needs to be solved before the footstep is completed image

mytonwalletorg commented 1 year ago

@delovoyhomie This issue is on STON.fi side.

  1. It uses the old TON Provider method to connect extensions instead of TON Connect, but it does not properly use window.myTonWallet interface (which allows to avoid conflicts with other legacy extensions), but rather uses a shared window.ton interface and shows a conflict error.

  2. Moreover, TON Connect button shows a QR code instead of showing a dialog to select a wallet that supports TON Connect, which would be a proper way to connect MyTonWallet after adding TON Connect support.

delovoyhomie commented 1 year ago

The work is paid only when it's completed 100%. There may be issues on the STON.fi side, but we need to ensure that the integration is done everywhere.

mytonwalletorg commented 1 year ago

This is a complete display of incompetence. You can disregard my application.

delovoyhomie commented 1 year ago

@mytonwalletorg, I contacted STON.fi about this issue. I do not want and will not ignore your messages. I want to resolve the issue so that everything works. Walk towards me

mytonwalletorg commented 1 year ago

There is nothing I can do to make it work on STON.fi side.

Apapirovskiy commented 1 year ago

Hello guys!

We implemented previously My Ton Wallet connection to STON.fi and all worked fine. But now something was changed in plugin and connect not working.

So, could @mytonwalletorg provide some examples or links - how to connect your plugin now. Because there are not website with examples or documentation portal for this. We'll fix connection as soon as possible.

Issue with modal window for TON Connect 2.0 for browser extension need more time.

mytonwalletorg commented 1 year ago

@Apapirovskiy Nothing was changed in plugin related to the old provider method. Can you confirm the other options on your site (specifically "Web TON Wallet") work correctly for you?

Hiyorimi commented 1 year ago

@Apapirovskiy @mytonwalletorg any updates here?

vtamara commented 1 year ago

Two things that I wish that MyTonWallet would support are:

  1. SSE Bridge. Of my understanding of https://github.com/ton-blockchain/TEPs/pull/115/files it is desirable that a wallet offers its own sse bridge and even allows the developer to choose a different one. Could you please provide an URL for the bridge that MyTonWallet offers (and include it in https://github.com/ton-blockchain/wallets-list/blob/main/wallets.json) and also instructions on how to change the bridge or maybe examples of bridges integrated in the backend of an application?
  2. TonProof. Of my understanding of https://ton-connect.github.io/sdk/modules/_tonconnect_sdk.html#getting-started the wallet needs to support TonProof in order to authenticate users in applications that have a backend. Could you please implement TonProof and examples of its usage in several programming languages for the backend (I wish Ruby on Rails)?
Apapirovskiy commented 1 year ago

@Hiyorimi now authorization using MyTonWallet works fine on ston.fi

delovoyhomie commented 1 year ago

Great! I will additionally check the integration work and if everything works, then the integration can be completed.

mehdixiavi commented 5 months ago

نوشتار با دوربین Hello I converted NatCoin to TonCoin and made a withdrawal, then the transaction failed, but it did not return to my account

mytonwalletorg commented 5 months ago

Hello,

Please, refer to https://t.me/MyTonWalletSupport.