ton-society / grants-and-bounties

TON Foundation invites talent to imagine and realize projects that have the potential to integrate with the daily lives of users.
https://ton.org/grants
313 stars 137 forks source link

Enhancing TON Wallet #28

Closed alfredonodo closed 1 year ago

alfredonodo commented 2 years ago

Summary

Enhancing TON Wallet by adding several key functionalities.

Context

TON Wallet is the only cross-platform open source wallet on the TON blockchain, but it lacks important features such as jetton, NFT, staking, purchasing and biometric authentication. It needs much improvement to be comparable to the wallets of major blockchains such as Ethereum and Solana.

Goals

Deliverables

Definition of Done

[ ] Update of official repositories and binary version.

Reward

liketurbo commented 2 years ago

I think it is too broad project. Maybe you should consider to decompose it to:

  1. Ton Wallet for IOS
  2. Ton Wallet for Android
  3. Ton Wallet for Google Chrome
  4. Ton Wallet for Firefox
  5. Add support for Jettons (add/list/send)
  6. Add support for NFTs (add/list/transfer)
  7. Add support for stacking
alfredonodo commented 2 years ago

I agree with you, however I think opening N steps is a little cumbersome. I would also add the desktop wallet. What do you propose?

liketurbo commented 2 years ago

@alfredonodo desktop wallet - it sounds nice 👍

liketurbo commented 2 years ago

@alfredonodo but if I were you I would have go through the list by creating for each one of them a new footstep, taking one and finishing...

alfredonodo commented 2 years ago

@alfredonodo but if I were you I would have go through the list by creating for each one of them a new footstep, taking and finishing...

I am not sure. What do they think @tsivarev @Hiyorimi ?

Hiyorimi commented 2 years ago

@alfredonodo but if I were you I would have go through the list by creating for each one of them a new footstep, taking and finishing...

I am not sure. What do they think @tsivarev @Hiyorimi ?

We need to check with TON Wallet repo and to make sure Footstep complies with their vision

alfredonodo commented 2 years ago

Meanwhile, I found the official repositories of the various wallets. Strangely, the one for the web wallet and browser extension is not in the main repository of TON. Also, only the desktop wallet and the web wallet/extension are recently updated while the android and iOS wallets have not been updated for over 2 years (probably the TON foundation promotes the third party wallet of tonkeeper and tonhub which already have many of the functions required by this issue). In my opinion, priority should be given to cross platform PC and web wallets to have all the functions. What should their vision be? Without updates, the only solution is to use a mobile device.

  1. TON Wallet desktop: official repository, last update 7 days ago
  2. TON Wallet android: official repository, last update 2 May 2020
  3. TON Wallet iOS: official repository, last update 30 April 2020
  4. TON Wallet web and browser extension: toncenter repository, last update 17 days ago
EmelyanenkoK commented 2 years ago

TON Wallet is expected to be as simple simple, stable, decentralized and reliable as possible. It is the last resort when everything else would be on fire for some reason. This is achieved through working via tonlib with network of lite-servers and checking proofs, instead of using trusted backend. Such decision prevents introducing new features into the TON Wallet: indeed for auto-detection of jettons and NFTs you need indexes which hard to run yourself, any zero-day in lets say image representation + mass jetton sending and we get all TON supply under attack etc.

There are a lot of things which user may want from their wallets, from paranoid air-gaped ways of sending message to custodial services. TON Foundation doesn't want to control the way owners work with their TONs and happy that there are teams in ecosystem (such as TonKeeper, TonWhales, Tegro and many others) which explore this area.

Hiyorimi commented 2 years ago

Maybe @DeFiTON can shine some light on Tegro Web Wallet plans?

DeFiTON commented 2 years ago

Oh, sure:

We launched the web version, just so that any user, from any device, can use it. Our data is stored in local storage.

Support for Jettons (add/list/transfer). We have already added support for tokens, automatically detects metadata.

Next update:

  1. NFT support and listing for sale directly from the wallet.
  2. TON DNS supported
  3. Swap tokens to TON via DEX in wallet
  4. [priority] Browser extension (Firefox and Chromium)
  5. Authorization (TON Auth), but the ability for the user to validate transactions

And as soon as Ledger adds the TON protocol, he will connect the wallet to it.

IOS/Android versions are not being developed at the moment

Hiyorimi commented 2 years ago

Oh, sure:

We launched the web version, just so that any user, from any device, can use it. Our data is stored in local storage.

Support for Jettons (add/list/transfer). We have already added support for tokens, automatically detects metadata.

Next update:

  1. NFT support and listing for sale directly from the wallet.
  2. TON DNS supported
  3. Swap tokens to TON via DEX in wallet
  4. [priority] Browser extension (Firefox and Chromium)
  5. Authorization (TON Auth), but the ability for the user to validate transactions

And as soon as Ledger adds the TON protocol, he will connect the wallet to it.

IOS/Android versions are not being developed at the moment

Thank you! Guess it concludes it the issue, doesn’t it @alfredonodo ?

Thank you for bringing the subject up in the meantime!

alfredonodo commented 2 years ago

@Hiyorimi Since one of the two main developers of the TON foundation responded, I don't think there is any room for change. What is regrettable is not having all the functionality described by the issue in a cross-platform PC or web wallet. Hopefully, tegro's wallet will be able to make up for the shortcomings listed above.