search

ton-society / grants-and-bounties

TON Foundation invites talent to imagine and realize projects that have the potential to integrate with the daily lives of users.
https://ton.org/grants
281 stars 128 forks source link

Enhance Tact Fireworks Demo Contract Test Suite #406

Closed reveloper closed 3 months ago

reveloper commented 8 months ago

Summary

Expansion of the test suite and the smart contract for Fireworks with unique edge cases.

Bounty Context

Why it's Important? To ensure broader use cases are covered and comprehensively explained, it is necessary to include further edge case examples to the Fireworks demo contract. This would allow developers interested in TON Blockchain to gain a deeper understanding of scenarios relating to messages, transactions, fees, and testing themes.

Problem showcase Currently, the Fireworks demo smart contract and its related test suite do not provide comprehensive coverage of edge cases. Likewise, the inclusion of such cases in the documentation is insufficient, leading to lack of clarity.

Potential Solution

  1. Add logic in the smart contract if required for the edge case demonstration.

  2. Create a unique edge case test in the test suite /tests/Fireworks.EdgeCases.spec.ts. Cover as much as possible TVM Exit Code and Tact contract exit code (output/*.md/Errors) cases.

  3. Add a clear, concise short description of the test case, enabling others to understand the rationale and implementation method easily.

References

REWARD

✨ Created with the help of TON Bounties Creator Bot.

alirezatabatabaeian commented 7 months ago

Hi @reveloper & @delovoyhomie I can handle this issue.

reveloper commented 7 months ago

@alirezatabatabaeian great! I want to warn you that perhaps the error list will be a little bit different from the current text. Let me double-check with Tact maintainers.

reveloper commented 7 months ago

@alirezatabatabaeian, how is it going, can you say an approximate date for this task?

alirezatabatabaeian commented 7 months ago

Hello dear @reveloper I've extracted all the new exit codes for TACT and their cause. I'm working on the contracts. Two weeks from now is the approximate date. But if you need it sooner, don't hesitate to tell me.

reveloper commented 7 months ago

@alirezatabatabaeian Great! All fine, take your time.

reveloper commented 5 months ago

@delovoyhomie fyi, as the original reward after all the tasks done looks unfair, I promoted the award by 200$ in TON, and now it's 500$ in TON total.

@alirezatabatabaeian thank you for your contribution in Tact and Tact docs.

alirezatabatabaeian commented 5 months ago

@reveloper Thanks it was a great collaboration for me

alirezatabatabaeian commented 5 months ago

I mention the new Tact Docs PR for the interested readers: https://github.com/tact-lang/tact-docs/pull/92

delovoyhomie commented 3 months ago

Rewards sent! Thank you for the contribution.

Questbook proposal