search

tonai / storybook-addon-themes

MIT License
83 stars 30 forks source link

Duplicate themes #51

Closed scottnath closed 3 years ago

scottnath commented 3 years ago

Hi,

I'm seeing the theme button twice in my toolbar.

I configured a theme in my preview.ts file:

addParameters({
  themes: [
    { class: 'ds-dark-theme', name: 'My Dark Theme' },
  ],
});

But I am ending up with two theme buttons in the toolbar. The other one looks to be the default theme. Is there a config I can set to turn off the default theme?

Screen Shot 2021-04-08 at 12 23 23 PM

thanks

tonai commented 3 years ago

The button that allows you to switch to light or dark theme comes from another addon: https://storybook.js.org/docs/react/configure/theming

The problem is that we share the same icon, so it looks like a duplicate button, but the content of the dropdown should be different.

tonai commented 3 years ago

Closing this as it would be solved with this issue: https://github.com/tonai/storybook-addon-themes/issues/50