tonarino / acoustic_profiler

Collaboration project with Jen
MIT License
1 stars 0 forks source link

Event timing #40

Closed goodhoko closed 1 year ago

goodhoko commented 1 year ago

note: I know our project is officially over but I just feel that a) this is getting really close to something useful b) I enjoy working on this so I may be submitting more PRs in upcoming days. I'll be glad for reviews but don't feel obliged in any way to respond to this. 🙌

The first commit merges the two testing probes into one, taking inspiration from @PabloMansanet's "modes" in the log probe)

The second adds another mode to this unified probe that can be used to test out the last commit in a controlled way.

And that last commit implements a half-baked change that plays sounds for the incoming events based on their internal timestamp rather than as they come. It's only half-baked because I have a few questions I wanted to discuss first.

btw: this seems to work! Running the test probe in burst mode with arbitrary parameters results in "clacks" played evenly spaced.

skywhale commented 1 year ago

@goodhoko thank you so much for making progress on this front! I wanted to start testing timed events for other event types, too, so I created https://github.com/tonarino/acoustic_profiler/pull/41. It partially overlaps with your 3rd commit here, so please have a look. I've addressed some of @strohel's review comments, too.

goodhoko commented 1 year ago

I'll close this as the crux of this PR (timed events) was completed in #41 and #42.

I'll post the left-over bit in a clean PR.