search

tonarino / actor

A minimalist actor framework aiming for high performance and simplicity.
MIT License
40 stars 6 forks source link

Make spawn builder harder to misuse #83

Closed mbernat closed 1 month ago

mbernat commented 1 month ago

This is a follow-up to #82 to make it a hard error when the user forgets to provide an address to an actor.

This breaks the API because now one has to call .with_default_capacity() if they really don't want to provide or configure the address.

Please let me know how to navigate the upgrade process. I only bumped the Cargo version but we'll also have to publish this, possibly prepare a changelog, etc.

mbernat commented 1 month ago

Nice! I have just some little docstrings suggestions.

Thanks, looking good, I applied all the suggestions.

Can you please pre-test this by using this branch in portal, and opening the required changes as a draft PR? To see the effect. Or maybe this doesn't require any portal changes?

It does require changes, here's the PR: https://github.com/tonarino/portal/pull/3333

I usually just use cargo-release. Let's pair on releasing the version once this is merged. Bumping the version in this PR is correct IMO (otherwise we could forget this is semver-breaking change).

Nice, let's do that.

mbernat commented 1 month ago

@strohel Please let me know when you can spare a minute to release this with me, thanks!