Player action logic

[PabloMansanet]

Business logic for the effects that player actions have on the world, as well as designing the Action enum itself.

Movement

Movement action should, well, move the character, but it may have non-obvious edge cases:

• What happens when a character walks into a bomb? In some bomberman games the bomb is pushed and starts sliding (though this is often with a powerup). We can assume the bomb is immobile for the MVP most likely.
• What happens when a character walks into a location that another character is moving to? How is this resolved? (it would be ideal if we could avoid solving it arbitrarily, such as through iteration order. An idea could be to just visually "bump" them and return them to their original position).

Placing bombs

• Where is the bomb placed? In most bomberman games, the bomb is placed exactly under you, which causes a bit of an exceptional state as it's the only "normal" way you can share position with a bomb. As soon as you move away from the bomb, you are unable to occupy the same tile again. I don't see a reason we can't do that ourselves, though it means we'll have to accomodate for this in the "tile" enum passed to the player (i.e. Tile::EmptyFloor(Some(player), Some(bomb))).
• What happens when the player tries to place a bomb and is unable to? (bomb limit). Animating the failure, even if it's just a little bomb with a red cross on top of their head, could do a lot for people to visually "debug" what they did wrong.

[strohel]

Where is the bomb placed? In most bomberman games, the bomb is placed exactly under you, which causes a bit of an exceptional state as it's the only "normal" way you can share position with a bomb. As soon as you move away from the bomb, you are unable to occupy the same tile again. I don't see a reason we can't do that ourselves

If that simplifies things I think I'd be completely okay to make bombs "passable" for everyone. (or in general to tweak the rules if that makes implementation/logic simpler)

Alternative would be to place the bombs in front of bombermans, but that would require adding "rotate me" actions and likely more corner-cases.

[PabloMansanet]

Yeah, I think the simplest thing will be to assume that bombermen and bombs can share a space. If we build around that assumption, then the decision of whether it's possible or not to walk into a bomb becomes a simple tweak :)

[skywhale]

I'll assign this to myself to implement a basic logic for bomb placement, with https://github.com/tonarino/bomberman-of-the-hill/issues/7.

[PabloMansanet]

Seems like bombs are working pretty well for now so I'll close this, and bring up another issue for improvements.