search

tonarino / bomberman-of-the-hill

13 stars 5 forks source link

Add simple upload server + submission script #18

Closed strohel closed 3 years ago

strohel commented 3 years ago

Extremely simple, but it works. Still a draft as I have to resolve TODOs in code and add some docs, but submitting for early feedback.

Resolves #1.

skywhale commented 3 years ago

@strohel do you want to go ahead and merge this?

strohel commented 3 years ago

@strohel do you want to go ahead and merge this?

I want to add a few last missing bits today (.env support for convenience, docs), and they it shal be merge-ready.

strohel commented 3 years ago

Added the last bits, this shall be now ready for final review/merge.

bschwind commented 3 years ago

This isn't in scope for the MVP but we'll want to host this over TLS for the meetup so ambitious players don't steal API keys 😄

strohel commented 3 years ago

This isn't in scope for the MVP but we'll want to host this over TLS for the meetup so ambitious players don't steal API keys.

Right, this isn't exactly secure. :sweat_smile: Though the ambitious players would have to do some MITM attack to get to see requests of the other players if I'm reasoning about it correctly.

PabloMansanet commented 3 years ago

It's looking good to me so I'm going to go ahead and merge :)