search

tonarino / panel-firmware

Firmware for the volume control hardware, targeting an STM32F4 board
MIT License
75 stars 10 forks source link

Implement fan control behind feature flag #29

Closed PabloMansanet closed 10 months ago

PabloMansanet commented 10 months ago

Going red because it depends on https://github.com/tonarino/panel-protocol/pull/14

Adds a feature flag that allows controlling fans and completely disables controlling lights, so that conflict isn't possible. Commands parsed for the unavailable feature are just ignored.

Untested, would be good to test with actual fans :).

Note that this preserves previous behaviour: the PWM are initialized at 0, which is inverted into a max duty cycle and means the fans start at max speed until set otherwise.

PabloMansanet commented 10 months ago

Updated dependency, this should be mergeable now. I also fixed two unrelated lints (just a double reference) to clear CI as they really didn't warrant another PR.

PabloMansanet commented 10 months ago

Closing as we're deferring this until hardware revision.

I'll leave the release on the panel-protocol, since it's the direction we want to follow eventually, but nothing will use it as a dependency for now (neither panel-firmware nor tonari)