search

tonarino / panel-firmware

Firmware for the volume control hardware, targeting an STM32F4 board
MIT License
75 stars 10 forks source link

Specify QEI Mode #33

Closed bschwind closed 8 months ago

bschwind commented 8 months ago

This currently works, but drafting for now because we should create an appropriate higher-level interface to specify the mode without unsafe usage.

Some more research is still needed - I would have expected mode 2 to work, based on the description, but maybe I have TI1FP2 and TI2FP1 mixed up.

Fixes https://github.com/tonarino/portal/issues/2666 (when the firmware is flashed).

goodhoko commented 8 months ago

Tested this throughoutly on lite-prague and it's consistently working. 🎉 Let's merge this ASAP and put up a PR for the upstream API independently.

bschwind commented 8 months ago

I'll test this once more on real hardware before merging.

bschwind commented 8 months ago

Tested again, working well!