tonazoon / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

Page Rendering #1

Open sdhunt opened 6 years ago

sdhunt commented 6 years ago

Nice work implementing a page that closely resembles the project specification. The fixed header works well, with the main content scrolling underneath.

A couple of visual issues I noticed:

screen shot 2018-03-19 at 12 56 35 pm

The first is that the navigation links should be on the right-hand side of the header. This is easily fixed with the justify-content attribute:

header {
  ...
  justify-content: space-between;
}

The second issue is that the main content appears "above" the header (there is a gap between the header and the top of the viewport. This, too, is easily fixed: explicitly set the margin of the body element to zero:

body {
  ...
  margin: 0;
}