search

tonazoon / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

HTML Source #2

Open sdhunt opened 6 years ago

sdhunt commented 6 years ago

The HTML source is reasonable. Good use made of whitespace and comments to break the code into readable chunks.

Great to see your use of semantic elements (<header>, <nav>, etc.) to provide more formal structure to the document.

Nice work remembering to define alt attributes for the images, for those viewers who have accessibility enabled.

One thing to be more careful about is indentation. This should accurately reflect the parent-child relationships between elements. For example: https://github.com/tonazoon/prj-rev-bwfs-tea-cozy/blob/master/teacozy/index.html#L87-L102

Closing </div> tags would never be indented the same amount... 

        ...

        <div class="location">
          <h3>Oakdale</h3>
          <p>515 Crescent Avenue</p>
          <p>Second Flor</p>
          <p>Portland, Maine</p>
        </div>
      </div>
    </div>

  </div>

  <!-- About Section -->
  <div id="contact">
    <h2>The Tea Cozy</h2>
    <h5>contact@theteacozy.com</h5>
    <h5>917-555-8904</h5>
  </div>