Open sdhunt opened 6 years ago
The CSS source looks good for the most part.
A couple of items to consider cleaning up:
(1) Be consistent with "style"
{
:
header { position: fixed; z-index: 1; width: 100%; height: 69px; border-bottom: 1px solid seashell; background-color: black; }
(2) When declaring multiple selectors for the same rule, place each on its own line: https://github.com/tonazoon/prj-rev-bwfs-tea-cozy/blob/b88cdbbe9f11026dffb8b0c480789ef4ec2ed217/teacozy/resources/css/style.css#L12-L15
h2, h3, h4 { margin: 0; padding: 10%; }
This helps accentuate the fact that the selectors are separate and not chained.
The CSS source looks good for the most part.
A couple of items to consider cleaning up:
(1) Be consistent with "style"
{
:
For example: https://github.com/tonazoon/prj-rev-bwfs-tea-cozy/blob/b88cdbbe9f11026dffb8b0c480789ef4ec2ed217/teacozy/resources/css/style.css#L37-L44(2) When declaring multiple selectors for the same rule, place each on its own line: https://github.com/tonazoon/prj-rev-bwfs-tea-cozy/blob/b88cdbbe9f11026dffb8b0c480789ef4ec2ed217/teacozy/resources/css/style.css#L12-L15
This helps accentuate the fact that the selectors are separate and not chained.