search

tonbo-io / tonbo

A portable embedded database using Arrow.
https://tonbo.io
Apache License 2.0
764 stars 42 forks source link

feat: adding reverse transactions #121

Closed vaibhawvipul closed 6 days ago

vaibhawvipul commented 2 months ago
ethe commented 2 months ago

Also test_reverse_scan_with_struct is not correct, I just add more assertions on it, you can check it on https://github.com/tonbo-io/tonbo/commit/af4a1d5b950002dfff0ec757dbb1eb478c2c9720, it shows that reverse iteration returns zero numbers of element, and rest of assertions are skipped. Because swap lower bound and upper bound does not make sense to crossbeam SkipMap, it does not support this to reverse the iteration in that way, you need to change the behavior of MutableScan to realize that.

ethe commented 6 days ago

close for stale， thanks vipul!