tonbo-io / tonbo

A portable embedded database using Arrow.
https://tonbo.io
Apache License 2.0
606 stars 42 forks source link

impl new derive macro to replace attribute macro #141

Closed Kilerd closed 1 week ago

Kilerd commented 1 week ago

this PR is to impl issue #58

main change:

refactor related:

further optimization:

Kilerd commented 1 week ago

and BTW I dont use tonbo in any of my projects, if you guys can provide some testcases are very helpful.

KKould commented 1 week ago

and BTW I dont use tonbo in any of my projects, if you guys can provide some testcases are very helpful.

This is a very big and meaningful PR, I will continue to follow up on the testing work

Kilerd commented 1 week ago

yep, you're right, and I recommend to review this PR commit by commit.

KKould commented 1 week ago

@Kilerd @ethe at present, macros does not support many configurable functions. Its core is to help users reduce code, so I only add tests to macro to verify the correctness. please take a look

https://github.com/tonbo-io/tonbo/pull/141/commits/7f7cb395ac4b6c2b0e5a85c4aedce45a42dee07c

ethe commented 1 week ago

This is pretty neat! Thanks to @Kilerd