search

tonerdo / readline

A Pure C# GNU-Readline like library for .NET/.NET Core
MIT License
810 stars 77 forks source link

None #14

Closed gitchomik closed 7 years ago

tonerdo commented 7 years ago

@gitchomik what are your thoughts on being able to also disable history? Also, I notice your commit isn't connected to your Github username, are you fine with this?

gitchomik commented 7 years ago

@tsolarin: For me, It's not a problem, that commit isn't connected to my Github username. Disabling history could be next step (the elegant way should use early exit, but currently the dirty way is to set .MaxItem = 0).

tonerdo commented 7 years ago

What about ReadLine.History.Disable()? And then ReadLine.History.Enabled to get whether or not (true/false) history is enabled. I'd love to know your thoughts

/cc @gitchomik

tonerdo commented 7 years ago

@gitchomik please merge the latest change to master. I updated the test script and I want the CI to run on this PR using that. Thanks!!!

tonerdo commented 7 years ago

@gitchomik deliberate?