History now has a global and per-call override.

tonerdo / readline

A Pure C# GNU-Readline like library for .NET/.NET Core

MIT License

810 stars 77 forks source link

History now has a global and per-call override. #25

Closed psylenced closed 7 years ago

psylenced commented 7 years ago

History now has a global setting to enable or disable it.

Read() now has a parameter to enable or disable history on a per-call basis.

Fixes #24

psylenced commented 7 years ago

Please note - I do not current have vs2017 installed on my local machine so the above changes were made blind and need testing.

psylenced commented 7 years ago

@tsolarin did you get a chance to follow this up?

tonerdo commented 7 years ago

@chris-gh sorry for the delay. I'll take a look this weekend

tonerdo commented 7 years ago

@chris-gh I was thinking we could just keep the DisableHistory property and remove the override. I'm trying to not have too much arguments in the ReadLine method.

tonerdo commented 7 years ago

This is going into the next release. Thanks @psylenced