search

tonesto7 / homebridge-smartthings-tonesto7

43 stars 86 forks source link

Feature Request: Inovelli Switch w/ Scenes #8

Closed codyrwhite-zz closed 4 years ago

codyrwhite-zz commented 5 years ago

I just moved to this fork because PDLOVE does not support the Inovelli switches and I saw an issue that recommended your fork.

https://github.com/pdlove/homebridge-smartthings/issues/274

I see that your version does load the switches as buttons but they do not work in HomeKit. The comments in the issue above show that I should comment out the undefined Button and HoldButton capabilities but it looks like your recent commits are more complete.

[1/5/2019, 7:47:00 PM] [SmartThings] Initializing homebridge-smartthings.SmartThings platform... [1/5/2019, 7:47:00 PM] [SmartThings] Fetching SmartThings devices. [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Back Deck Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Basement Stairs Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Bedroom Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Dining Room Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Front Outlet) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Garage Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Laundry Room Fan) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Laundry Room Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Main Hallway Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Master Bathroom Fan) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Master Bathroom Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Porch Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Office Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Upstairs Hall Light) [1/5/2019, 7:47:01 PM] [SmartThings] Button: (Upstairs Light) [1/5/2019, 7:47:01 PM] [SmartThings] Unknown Capabilities: ["Holdable Button","Health Check"] [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Back Deck Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Basement Stairs Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Bedroom Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Christmas Tree'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Dining Room Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Front Outlet'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Garage Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Laundry Room Fan'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Laundry Room Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Main Hallway Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Master Bathroom Fan'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Master Bathroom Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Porch Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Office Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Upstairs Hall Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Upstairs Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Master Bedroom Ceiling Fan-Light'... [1/5/2019, 7:47:01 PM] [SmartThings] Initializing platform accessory 'Security Alarm'...

Is there anything I and do to correct this.

codyrwhite-zz commented 5 years ago

@erocm123 is the usage of the device handler Inovelli Switch NZW30 w/ Scenes creating a limitation in HomeKit.

The device handler Inovelli Switch NZW30 w/ Scenes seems to prioritize the switch to a button press to allow the handling of Scene switching in smart things.

The device handler Inovelli Switch NZW30 no longer uses the button capability and uses the switch capability and this is working with HomeKit.

For now since I am not using the Scene feature of the switch, I have changed the device handler from Inovelli Switch NZW30 w/ Scenes to Inovelli Switch NZW30.

Now the devices are working in HomeKit.

codyrwhite-zz commented 5 years ago

Looks like this pull request might fix this issue https://github.com/tonesto7/homebridge-smartthings-tonesto7/pull/10

@shnhrrsn you don't happen to have any of these switches to test with do you?

erocm123 commented 5 years ago

Yeah, we talked about this a while ago. It seems that the bridge sees the button capability and doesn't correctly add the device. Can the bridge not support multiple capabilities for a single device (button & switch)?

shnhrrsn commented 5 years ago

@codyrwhite Unfortunately I do not, I've only been able to test with the button that Samsung/SmartThings themselves make.

@erocm123 I think that'd need to be added to HomeKit as separate devices but I’m definitely not an expert here. The button device supports multiple buttons as a single button but I don't think it supports button + switch.