tonesto7 / homebridge-smartthings

SmartThings Homebridge Plugin
385 stars 767 forks source link

(BUG) Support thermostat that can't be turned off. #335

Open torandreroland opened 4 years ago

torandreroland commented 4 years ago

Verify the following before opening an trouble issue

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!


About Your Setup

Expected Behavior

Thermostats that don't support thermostat mode "off" should not be able to set Target Heating Cooling State to off.

Current Behavior

Thermostats that don't support thermostat mode "off" are able to set Target Heating Cooling State to off, since this is assumed in the code.

Steps to Reproduce (for bugs)

Provide a link to a live example, or an unambiguous set of steps to reproduce this bug. Include code to reproduce, if relevant

1. 2. 3. 4.

Context

I have a thermostat that controls the floor heating that can't be turned off. When setting Target Heating Cooling State to off the Apple Home App becomes unresponsive. I think the plugin should adhere to the supported thermostat modes stated by the device, instead of assuming that it's only applicable.


Please include a copy of any relevant log output to assist in tracking down the bug