search

tonesto7 / homebridge-smartthings

SmartThings Homebridge Plugin
385 stars 767 forks source link

[Feature Request] Television support #340

Closed radiocolin closed 4 years ago

radiocolin commented 4 years ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like I would love if my Samsung Tizen TV, which is connected to SmartThings, could be translated to Homebridge as a TV.

Describe alternatives you've considered I'm currently using homebridge-tizen, so this would mean one less dependency.

swamplynx commented 4 years ago

“ I'm currently using homebridge-tizen, so this would mean one less dependency.”

I feel like this would be one more dependency (ST) actually. For everything that has a homebridge plugin (e.g. Ring, Harmony), I use the native homebridge plugin and specifically do not proxy through ST.

radiocolin commented 4 years ago

My thought is that if SmartThings natively supports TVs, and homebridge-smartthings-v2 could expose that directly to homebridge, rather than relying on the developer of homebridge-tizen back-hacking the Tizen API.

I wonder if there is also functionality that the TV exposes to SmartThings that can only be accessed through SmartThings (eg: Ambient Mode, or the status of non-app inputs).

tonesto7 commented 4 years ago

I will try my best but it's going to take time as I don't have any Samsung TVs that integrate with ST.

Plus, the TV stuff is a bit more complicated. Maybe over the next few months, I will snag up a TV.

radiocolin commented 4 years ago

I have a TV, and a smart things hub, and I use this plug-in. I also have a working knowledge of using a MITM proxy to intercept API calls. Let me know if there’s any way I can help.

cnnn commented 4 years ago

In my case I have to rely on a separate plugin as ST no longer finds my 2016 KS8000 TV.

cladmonitor commented 4 years ago

Can I make a comment about this vs tizen hb plugin. The Tizen plugin specifically uses WOL to turn on TVs since the API endpoint is not available once the tv has gone to sleep (>30sec), I've found the Samsung Smartthings implementation for TVs to be lacking but moving to the Tizen plugin is much better and solved all those headaches.

Honestly the separation in the plugins is good, overwhelming one developer with features distinctively different then he platform suggests seems odd. If it was just to support what ST allows currently thats great but I want to be sure everyone understands duplicating what the Tizen HB plugin has is not really practical.

radiocolin commented 4 years ago

If it was just to support what ST allows currently thats great but I want to be sure everyone understands duplicating what the Tizen HB plugin has is not really practical.

I'm asking to support the television functionality that SmartThings allows currently. If you have a Samsung TV, it shows up as a ST device in your hub and ST app.

I'm not asking for duplication of the Tizen plugin.

cladmonitor commented 4 years ago

Colin but all it would do is turn the TV off... it couldn’t t turn it on. What’s the point of half the functionality? If you wanted individual buttons to do things that would be highly Specific to each TV.

What specific features would you like to see?

Thanks, [image: Connetic Corp] http://www.connetic.com/ Eric Sakariasen CTO, Network Operations T: 866-226-6638 E: support@connetic.net | W: www.connetic.com

On Jan 29, 2020, at 9:57 AM, Colin Weir notifications@github.com wrote:



If it was just to support what ST allows currently thats great but I want to be sure everyone understands duplicating what the Tizen HB plugin has is not really practical.

I'm asking to support the television functionality that SmartThings allows currently. If you have a Samsung TV, it shows up as a ST device in your hub and ST app.

I'm not asking for duplication of the Tizen plugin.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/homebridge-smartthings-v2/issues/20?email_source=notifications&email_token=AH2UNQ6DB2CISYILGSRU22TRAG7P3A5CNFSM4J4RGJEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKIES6Q#issuecomment-579881338, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2UNQ6TMIVASJEEYUME463RAG7P3ANCNFSM4J4RGJEA .

radiocolin commented 4 years ago

Where are you drawing that conclusion from? The SmartThings app allows full control of all functions of the TV, including power in both directions.

I am also not sure where you’re determining that buttons would be specific to each TV? The smart things app is from Samsung, and exposes all the features of the Samsung television as a device in ST. There is a standard set of TV controls in HomeKit that they would be mapped back to.

The feature I would like to see is the television in smart things exposed to HomeKit, with support for any television functionality supported in HomeKit, including power, changing of inputs, and using the remote from control center.

B101D69E-F32E-494B-9941-5A6FE847657F

tonesto7 commented 4 years ago

I'm going to be honest... I'm not sure I will be able to add support for TVs anytime soon. I don't have any newer Samsung TVs that SmartThings supports.
I don't really have the time to develop support for something in the blind and work with others to test. That's very time-consuming. I'm not saying that won't ever happen it's just difficult for me to imagine with my current work and project loads.

scoobaspeaz commented 4 years ago

Just to add to this the Samsung TV has a smart hub within itself that connect directly to Samsungs cloud via your Samsung login. Your SmartThings Hub doesnt actually link up with it but only your smartthings app does. At least thats how I understood it once I tried this. I just went back to using the samsung-tizen plugin

radiocolin commented 4 years ago

Interesting! Thanks for the insight. Sounds like they’re doing some annoying jiggery pokery behind the scenes.

-CW

On Feb 19, 2020, at 4:18 AM, scoobaspeaz notifications@github.com wrote:

 Just to add to this the Samsung TV has a smart hub within itself that connect directly to Samsungs cloud via your Samsung login. Your SmartThings Hub doesnt actually link up with it but only your smartthings app does. At least thats how I understood it once I tried this. I just went back to using the samsung-tizen plugin

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

tonesto7 commented 4 years ago

I'm closing this for now as I have no plans to support this in the future