tonesto7 / homebridge-smartthings

SmartThings Homebridge Plugin
384 stars 767 forks source link

Updating fan speed controllers to properly align HomeKit and SmartThings statuses #375

Closed jonnyborbs closed 3 years ago

jonnyborbs commented 3 years ago

Minor updates to two files as discussed in https://github.com/tonesto7/homebridge-smartthings/issues/326 - HomeKit wasn't aligning Low/Medium/High to the SmartThings percentages for 3 speed fan DTH's properly.

Thanks to @jfsteele for the code suggestions, all credit to them for the fix here - I just hoped submitting a PR would accelerate getting this fixed.

tonesto7 commented 3 years ago

Thanks for submitting these. I noticed this issue a couple of days and meant to look at it so the timing is perfect I will merge them in today.

jonnyborbs commented 3 years ago

Thanks a ton! Now I can't remember - how do we as consumers of the smartapp actually take advantage of this update? I can't remember, do we need to update the repo in the ST Groovy console, or does it get compiled into the plugin and updated via the HomeBridge UI directly?

jonnyborbs commented 3 years ago

Hi there! Any idea when we might see a release of the plug-in cut so that these fixes are available for use? Thanks and happy holidays 🙂

jonnyborbs commented 3 years ago

Hey @tonesto7 - it's been quite some time since this was merged, but there's been no version bump that I can see to the plugin for the Homebridge app to take advantage of. Any idea when that might happen? Is this repo still active?