search

tonesto7 / nest-manager

NST Manager (SmartThings)
https://community.smartthings.com/t/release-nst-manager-v5-0/
Other
397 stars 2.18k forks source link

No clientID, clientSecret fields in Settings section #553

Open Rob-ee opened 6 years ago

Rob-ee commented 6 years ago

Verify the following before opening an issue:

About Your Setup:

Expected Behavior

In ST IDE, for Nest Manager SmartApp, according to PDF , there should be clientID & ClientSecret fields under "Settings" section

Current Behavior

There are no fields under "Settings" section, just text "Add setting definitions in the source code and then set the values here"

Steps to Reproduce (for bugs)

  1. Installed Nest manager via auto ST Community installer
  2. Followed instructions in https://rawgit.com/tonesto7/nest-manager/master/Documents/instructions/Nest%20Developer%20-%20Nest%20Product.pdf and created NEST dev account, copied Product ID, Product Secret to clipboard
  3. Opened the "Settings" section of Nest Manager SmartApp, but there are no fields, just a message "Add setting definitions in the source code and then set the values here"

Context

Watso4183 commented 6 years ago

Ran into the same issue myself. Installed via ST Community installer as well.

MarkToon commented 6 years ago

Did this ever get solved? Ive ran into the same issue myself.

safetymonkey commented 6 years ago

+1. I'm having the same issue.

Rob-ee commented 6 years ago

I was playing around with it and honestly I can't remember exactly what I did to resolve it, but I think it had something to do with manually downloading each script and running it, I think that I figured out that the bundled installer was a bit different than the last version

On 28.3.2018. 19:17, safetymonkey wrote:

+1. I'm having the same issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-376965537, or mute the thread https://github.com/notifications/unsubscribe-auth/AIcWcr3ZMZgeeWUJLuTHJnNOZMHXWbVYks5ti8WZgaJpZM4SJazz.

safetymonkey commented 6 years ago

Well, sure. The problem doesn't exist if I download the raw versions of the scripts and input them in the IDE directly. But this bug relates specifically to the app installer, which is listed as the "strongly recommended" option. :)

On Wed, Mar 28, 2018 at 10:57 AM, Rob-ee notifications@github.com wrote:

I was playing around with it and honestly I can't remember exactly what I did to resolve it, but I think it had something to do with manually downloading each script and running it, I think that I figured out that the bundled installer was a bit different than the last version

On 28.3.2018. 19:17, safetymonkey wrote:

+1. I'm having the same issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553# issuecomment-376965537, or mute the thread https://github.com/notifications/unsubscribe-auth/ AIcWcr3ZMZgeeWUJLuTHJnNOZMHXWbVYks5ti8WZgaJpZM4SJazz.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-376978625, or mute the thread https://github.com/notifications/unsubscribe-auth/AALeCIG1GifUAxO2ZCV-3fFY0poNvIASks5ti88kgaJpZM4SJazz .

ramginuga commented 6 years ago

+1, same issue

cdevereu commented 6 years ago

+1 As a new ST user this is my first community installed smart app, following the "Strongly recommended" option.

bbuchan10 commented 6 years ago

I resolved this by clicking "code" in the right corner in the IDE then Clicking save. That seemed to have triggered the IDE to re-digest the definitions.

cdevereu commented 6 years ago

I also resolved this by manually copying/pasting the Nest Manager raw code from Github (https://github.com/tonesto7/nest-manager/blob/master/smartapps/tonesto7/nest-manager.src/nest-manager.groovy) over the top of the existing code put there by the community installer. Save > Publish then the settings appeared

safetymonkey commented 6 years ago

Again, copying the code defeats the purpose of the recommended installation method. I can and have copied the code over, but this is a bug with the recommended solution.

On Fri, Apr 6, 2018 at 9:49 AM, Chris Devereux notifications@github.com wrote:

I also resolved this by manually copying/pasting the Nest Manager raw code from Github (https://github.com/tonesto7/nest-manager/blob/master/ smartapps/tonesto7/nest-manager.src/nest-manager.groovy) over the top of the existing code put there by the community installer.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-379311334, or mute the thread https://github.com/notifications/unsubscribe-auth/AALeCPRmPSmwunbFjxdUMeTQ31glUmuUks5tl5x-gaJpZM4SJazz .

bbuchan10 commented 6 years ago

I do not believe it is an issue with the automated installation. As the definitions for the fields are in the code. Just simply saving the code again, not pasting over it(that is extra work), resolves the issue. I believe it is an issue with the IDE ingesting the definition the first time.

safetymonkey commented 6 years ago

Then the instructions should probably be updated to note this workaround.

On Fri, Apr 6, 2018 at 10:01 AM, bbuchan10 notifications@github.com wrote:

I do not believe it is an issue with the automated installation. As the definitions for the fields are in the code. Just simply saving the code again, not pasting over it, resolves the issue. I believe it is an issue with the IDE ingesting the definition the first time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-379314767, or mute the thread https://github.com/notifications/unsubscribe-auth/AALeCEOC7o1ew5-QDK_BiLowFigWbV4Wks5tl593gaJpZM4SJazz .

bugzc commented 6 years ago

Same issue here. I can confirm going into code and hitting 'save' did the trick. A note in the Wiki would be helpful.

automate2win commented 6 years ago

Had the same issue as everyone else above and going to the code and hitting "save" worked for me as well. I agree with bugzc

VTChevalier commented 6 years ago

Yes - agree the guide for creating your own nest dev id (https://rawgit.com/tonesto7/nest-manager/master/Documents/instructions/Nest%20Developer%20-%20Nest%20Product.pdf) needs to be updated to mention quickly saving the code in IDE to allow the settings to refresh, wasted a few mins on this myself.

dcurrie1961 commented 6 years ago

@cdevereu Your solution worked for me. I did a faked an upgrade and republish. Settings appeared and it was fine.