search

tong / hxmpp

Haxe XMPP library
65 stars 8 forks source link

Using ip for domain in jid #22

Closed RudolfVonKrugstein closed 10 years ago

RudolfVonKrugstein commented 10 years ago

According to wikipedia, the domain part in the jid is allowed to be a ip address. For testing, I use an xmpp server on the local machine. But when I try "me@127.0.0.1" for the jid in Stream::open, I get "invalid jid [me@127.0.0.1]" thrown at me.

tong commented 10 years ago

Well, thats's right. RFC says: The domain identifier for every server or service that will communicate over a network MAY be an IP address but SHOULD be a fully qualified domain name. http://xmpp.org/rfcs/rfc3920.html#addressing

With hxmpp you can use an IP address as domain name if the compiler flag -D jabber_debug is set. I am not sure if we should change this because it would require to use PLAIN SASL as authentication mechanism (others use fully qualified domain names for digest calculation) and imho it's a bad practice to send passwords as plain text under any circumstances (heartbleed!).

RudolfVonKrugstein commented 10 years ago

Well, turning debugging on is fine for me.