tongdun / td-redis-operator

一款强大的云原生redis-operator,经过大规模生产级运行考验,支持分布式集群、支持主备切换等缓存集群解决方案…The powerful cloud-native redis-operator, which has passed the test of large-scale production-level operation, supports distributed clusters and active/standby switching ...
Apache License 2.0
505 stars 89 forks source link

Remove cluster creation from helm #8

Closed IDerr closed 2 years ago

IDerr commented 2 years ago

Remove cluster creation from Helm, a cluster and a standalone redis is created when crd is installed, I think it's better to let the user decide if they want to create one, or let them the choice to do it. (Perhaps in another cluster)

Thanks a lot for your work

DoubleJ213 commented 2 years ago

OK.Shall we divide the pre helm chart into two parts or add a cluster and a standalone charts @houseonline @gaoshengL

IDerr commented 2 years ago

yes perhaps, or we could use some variables to deploy or not the cluster

DoubleJ213 commented 2 years ago

You can use --set type=cluster or type=standby to choice which kind of redis to be installed . such as only install RedisCluster by using the command $ helm install --namespace=redis [RELEASE_NAME] td-redis-operator/td-redis-operator --set type=cluster

For more differents about RedisCluster and RedisStandby https://github.com/tongdun/td-redis-operator/wiki/Principle-of-Main-and-Standby-Realization#architecture https://github.com/tongdun/td-redis-operator/wiki/Principles-of-Cluster-Implementation#architecture

IDerr commented 2 years ago

perfect, i think by default we should add a type none, to deploy 0 cluster (if we want a cluster in another namespace for example)

DoubleJ213 commented 2 years ago

A chart deploy without cr maybe not friendly to new users. If you want to deploy operator and cr in different ns , you can modify it in your branch ?

DoubleJ213 commented 2 years ago

btw if use --set type=none now, no redis cr will be deployed. the redis cr deployed only if you input --set type=cluster\standby\all or noting to be set

IDerr commented 2 years ago

oh ok, great, i'll do something like this

IDerr commented 2 years ago

It's working great for me i think you could merge this pr