search

tongocthao / code-a-website

Follow some wireframes, a sitemap & given some content, write the HTML for a full website.
0 stars 0 forks source link

Fix banana.html #1

Open tongocthao opened 3 years ago

tongocthao commented 3 years ago

Hi, I see some meta tag and skip links that talked about in the Markbot for my HTML (banana.html) and so on for the rest of fruits html.

Screen Shot 2021-07-08 at 8 46 08 PM Screen Shot 2021-07-08 at 6 13 59 PM

@anna-pokhilenko @abhaysharma

abhaysharma commented 3 years ago

@tongocthao you do not need to add the meta tags in the header. remove this code.

<meta itemprop="ICBM" content="">
<meta itemprop="geo.position" content="">
<meta name="geo.region" content="">
<meta name="geo.placename" content="">
<meta property="og:type" content="">
<meta property="og:locale" content="">
<meta property="og:title" content="">
<meta property="og:url" content="">
<meta property="og:image" content="">
<meta property="og:site_name" content="">
<meta property="og:description" content="">
<meta name="twitter:card" content="">
<meta name="twitter:site" content="">
tongocthao commented 3 years ago
Screen Shot 2021-07-09 at 2 32 38 PM

Hi, I removed those tags, it has improved better; however I don't know about this issue. Because I had main> h1+img+p already. Could you please have a look for me, Professor? Thanks so much ! @abhaysharma