tongwentang / tongwentang-extension

MIT License
132 stars 15 forks source link

Cannot change bracket like “?” & “……” #13

Closed katie-1125 closed 3 years ago

katie-1125 commented 3 years ago

Dear, thanks for your great contribution and you saved my life a lot when reading novel Just want to report a small issue, for example in below link: http://www.jjwxc.net/onebook.php?novelid=4001734 I have set up the rule for changing “ & ” to 「&」but it didn't reflect to those lines that only contain “?” & “……” Then I tried set up rule as changing “?” to 「?」but it still the same Can you assist? Thank you very much!

t7yang commented 3 years ago

Duplicate #11 , please search before issue. And btw. there is not more happen on 2.1.1 on my pc now, so could you try on latest 2.1.1 with a fresh profile?

katie-1125 commented 3 years ago

Hi, apologize for the duplicate I also tried in VM with newly installed Chrome & 2.1.1, but issue still the same, not all quotation brackets can be updated. 1 2

t7yang commented 3 years ago

Because the node tree walker skip node text without any Chinese character, currently the regular expression test only for character but no punctuation. I'll improve this in the future release of tongwen-core.