search

toni-heittola / js-datatable

JQuery plugin to generate dynamic HTML tables with data visualization https://toni-heittola.github.io/js-datatable/
MIT License
39 stars 19 forks source link

Update for Bootstrap 4 ? #10

Open bcopy opened 2 years ago

bcopy commented 2 years ago

Glyphicons is desupported in Bootstrap 4, and replaced by Font Awesome. Would it be possible to update js-datatable ?

I can submit a PR, I can see the following update being required :

Anything else ?

toni-heittola commented 2 years ago

js-datatable is build on top of bootstrap-table v1.11.1 which supports only Bootstrap v3. The current version (v1.19.1) of bootstrap-table is supporting Bootstrap v4. Updating the code to use a newer bootstrap-table should be a relatively straightforward process, but it might require major code updates to js-datatable.

I understand that js-datatable is a bit outdated as it is relying on Bootstrap v3, and I am happy to receive PRs to fix this.