search

toni-moreno / snmpcollector

A full featured Generic SNMP data collector with Web Administration Interface for InfluxDB
MIT License
286 stars 53 forks source link

xorm update: #508

Closed dcarbone closed 2 years ago

dcarbone commented 2 years ago
toni-moreno commented 2 years ago

Hello @dcarbone , thank you this PR.

The new feature will be welcomed , but there is a failing check , because it has not been well designed. It seems like is not working when a PR is done from other user repo ( obviously without the needed credentials for docker hub login ). Could you please remove on your branch these lines from the action ( https://github.com/toni-moreno/snmpcollector/blob/master/.github/workflows/pr-docker-image-test.yml#L25-L30) to test the docker image generation again ?

dcarbone commented 2 years ago

@toni-moreno: anything else I can add to this PR to get it accepted?

toni-moreno commented 2 years ago

@toni-moreno: anything else I can add to this PR to get it accepted?

Only was waiting for your reply in the previous question.

@dcarbone , thank you in advance for your work. Prior to merge I would like to know what DB are you working on and what other db engines have you tested after this change has been done.

@dcarbone we need to know about working db's to add as a feature in the documentation

dcarbone commented 2 years ago

@toni-moreno: sure, so I can personally verify that it works with mariadb, and the documentation for postgres 9.1+ and mysql 5.6+ indicate that TRUE is valid constant for this field type.