tonianer / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

mupen64plus-core/src/main/zip/ioapi.h: "#define OF _Z_OF" prevents build on Ubuntu 12.04 #506

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Describe your system:
 - Operating System (be specific): Ubuntu 12.04
 - Machine type (32-bit or 64-bit): x86_64
 - Mupen64Plus version: current from hg as of a few minutes ago

The header file tries to work around some zlib namespace pollution issues but 
breaks compiling along the way. Removing the 3 lines

#ifndef OF
#define OF _Z_OF
#endif

solves the problem. I tried 'export CPPFLAGS="-DOF=_Z_OF"' before and that 
broke compiling somewhere in savestates.c, so I guess those header files do it 
correctly.

Original issue reported on code.google.com by madig...@gmail.com on 15 Jul 2012 at 11:44

GoogleCodeExporter commented 8 years ago
I think this workaround from 313a6142c4f5 should be removed. Gentoo people can 
just build mupen64plus with libminizip instead of the embedded version.

Original comment by s...@narfation.org on 15 Jul 2012 at 12:11

GoogleCodeExporter commented 8 years ago
I've created a workaround. Can you please try 7c0a373e8d13? You can get it from 
https://bitbucket.org/ecsv/mupen64plus-core (or from Richard42's repo after he 
merged it)

Original comment by s...@narfation.org on 15 Jul 2012 at 12:17

GoogleCodeExporter commented 8 years ago
Seems to work :)

Original comment by madig...@gmail.com on 15 Jul 2012 at 10:52

GoogleCodeExporter commented 8 years ago
Thanks for the test. Richard already merged it. So I will close this bug

Original comment by s...@narfation.org on 16 Jul 2012 at 1:19