tonib / kaichronicles

Lone Wolf game books player
GNU General Public License v3.0
63 stars 16 forks source link

"Hidden" skill bonus not carried over from Kai to Magnakai books #5

Open jfsp opened 6 years ago

jfsp commented 6 years ago

When you finish playing the books in the Kai series, thus obtaining all the Kai disciplines, the bonuses associated with these are not applied when playing the Magnakai books.

For example, the following Kai skills are "lost":

The "carry over" of Kai disciplines was considered a "hidden bonus" by Joe Dever as described in Lone Wolf Club Newsletter Summer Special 1987 (for full details see https://www.projectaon.org/en/ReadersHandbook/TopicalH).

I believe this can be fixed by removing the following two lines from www/data/mechanics-6.xml:

<dropDisciplines />

Which would mean that Kai disciplines would not be removed.

In addition to this, it is to be noted that the skills are cumulative, which could require changes in other parts of the code. For example, in src/ts/controller/mechanics/mechanicsEngine.ts the function healingDiscipline() would need to be modified changing:

    if( state.actionChart.currentEndurance < state.actionChart.getMaxEndurance() )
        actionChartController.increaseEndurance(+1, true);

to

    if( state.actionChart.disciplines.contains('healing') && state.actionChart.currentEndurance < state.actionChart.getMaxEndurance() )
        actionChartController.increaseEndurance(+1, true);
    if( state.actionChart.disciplines.contains('curing') && state.actionChart.currentEndurance < state.actionChart.getMaxEndurance() )
        actionChartController.increaseEndurance(+1, true);

That way the bonus would be applied twice: once for the Healing Kai discipline and another one for the Curing MagnaKai discipline.

tonib commented 6 years ago

Added to the list of pending works (with other stuff at https://www.projectaon.org/es/foro3/viewtopic.php?f=1&t=1330)

It will be not so easy as remove the tag "dropDisciplines", but it can be done. You cannot left the previous books disciplines on the action chart, because they don't have a description on the book 6+.

Thank you!

mikix commented 6 years ago

This is just my opinion, which is no doubt worth less than Joe's, but that "1EP every page" bonus is too strong. I can see why it was nerfed after the first 5 books. I think the books are more interesting as a game without these bonuses and force the reader to be appropriately careful. But ::shrug::

rendall commented 6 years ago

FWIW, I agree with the OP. The character is a MagnaKai, and should have all of the powers of a normal Kai, along with MagnaKai powers.

Baljak commented 5 years ago

In addition to this, it is to be noted that the skills are cumulative, which could require changes in other parts of the code. For example, in src/ts/controller/mechanics/mechanicsEngine.ts the function healingDiscipline() would need to be modified changing:

    if( state.actionChart.currentEndurance < state.actionChart.getMaxEndurance() )
        actionChartController.increaseEndurance(+1, true);

to

    if( state.actionChart.disciplines.contains('healing') && state.actionChart.currentEndurance < state.actionChart.getMaxEndurance() )
        actionChartController.increaseEndurance(+1, true);
    if( state.actionChart.disciplines.contains('curing') && state.actionChart.currentEndurance < state.actionChart.getMaxEndurance() )
        actionChartController.increaseEndurance(+1, true);

That way the bonus would be applied twice: once for the Healing Kai discipline and another one for the Curing MagnaKai discipline.

While I agree Kai bonuses should apply for a player who finished the first five books, I disagree on this part. It was explicitly mentioned by Joe Dever himself that Kai bonuses and Magnakai bonuses of the same discipline are not cumulative (it was stated in the Grand Master series of books, but before that it was mentioned in a Lone Wolf Club Newsletter).

In your example, choosing Healing does not grant an additional +1 EP per section if you finished the previous 5 books. You only get +1 EP per section, not 2. The same applies for Weaponskill and Weaponmastery: if you finished the Kai series having Weaponskill in sword, and if you choose Weaponmastery with the same weapon, you only get +3 CS when using sword in combat. The 'hidden' bonus there is only if you don't select Weaponmastery in sword, you still get +2 CS for having the Kai discipline.