toniblyx / alfresco-backup-and-recovery-tool

Alfresco BART is a tool written in shell script on top of Duplicity to do Alfresco backups and restore from a local file system, FTP, SCP or Amazon S3.
Apache License 2.0
96 stars 48 forks source link

Extra backslash at line 745? #28

Closed enribar closed 7 years ago

enribar commented 7 years ago

Hi, i created a cron script that launches alfresco-bart.sh collection weekly, to check backup status. I noticed that in cron log it warns me of "command not found" at line 745 of alfresco-bart.sh.
At the end of that line there is a backslash, indeed...as far as I understood it is not necessary, or am I wrong? Here is the line:

$DUPLICITYBIN collection-status -v0 ${NOENCFLAG} --log-file=${ALFBRT_LOG_FILE} $DEST/$INDEXTYPE/backup; \

toniblyx commented 7 years ago

Thanks @xjobex, have you tried removing it? Not sure if the error is due to that or the next line here: https://github.com/toniblyx/alfresco-backup-and-recovery-tool/blob/master/src/alfresco-bart.sh#L746

Can you test it?

enribar commented 7 years ago

Yes, I removed it and left my cron script running for a few weeks...I did not find any more error lines in cron logs.

In the actual release of alfresco-barth.sh the backslash I removed is at line 741: https://github.com/toniblyx/alfresco-backup-and-recovery-tool/blob/master/src/alfresco-bart.sh#L741

toniblyx commented 7 years ago

@douglascrp have you see this issue? Have you tested it?

douglascrp commented 7 years ago

No, I haven't.

Are you going to change this?

toniblyx commented 7 years ago

I can't test it anytime soon, can you?

douglascrp commented 7 years ago

Well, it depends on what you mean by soon :D I will try to do so in the next week, as I still have some things to finish until the end of this week. I also have other issues I have to finish in the project, as the project version, so I will try to do everything at once.

douglascrp commented 7 years ago

@toniblyx Ok, I could finally test and fix it, as described by @xjobex

Thank you @xjobex

douglascrp commented 7 years ago

Fixed with #32