Vue 3 compatibility - Githubissues

tonickkozlov / vue-tweet-embed

Embed tweets in your vue.js app

111 stars 27 forks source link

Vue 3 compatibility #72

Open jacksongross opened 2 years ago

jacksongross commented 2 years ago

Update vue package and peerDependency to use version 3
Update puppeteer as it was super old
Update syntax for render function to be Vue 3 compatible
Fix tests to work with changes
Fix bug where non-integer tweetId would throw an uncaught error in the iframe preventing the widget from loading, and not being caught by this package so the error handling wouldn't work correctly.

Fresh-Dev-zunairzakir commented 2 years ago

@jacksonGross, Can you please confirm when this fix will be deployed into Production?

Fresh-Dev-zunairzakir commented 2 years ago

@tonickkozlov , Can you provide some update on this merge request?

jacksongross commented 1 year ago

@Fresh-Dev-zunairzakir I've published my fork here if you'd like to use it -- https://github.com/jacksonGross/vue-tweet-embed

tonickkozlov commented 1 year ago

@jacksongross many thanks for working on this fix. Sorry I didn’t have much time to look into it earlier. Could you please try to see why the builds are not completing? Then we can merge.

jacksongross commented 1 year ago

~~@tonickkozlov I don't have access (or can see a way) for me to check the issue with the builds.~~ Can see this PR never triggered a build, which makes sense why it says it's still waiting to be reported in the PR status checks. Not sure why this isn't being picked up here, any ideas?