search

toniebox-reverse-engineering / teddy

With this tool you can dump existing files for the famous audio box or create custom ones.
261 stars 33 forks source link

Leave less sensitive information in decoded files #60

Closed steve8x8 closed 1 year ago

steve8x8 commented 1 year ago

I cannot use TeddyBench, so this may already be addressed in the latest code, but Teddy 1.20 writes the full input file path to the decoded .ogg files:

$ ogginfo 500304E0-$serial\ -\ Track\ #01.ogg 
Processing file "500304E0-$serial - Track #01.ogg"...

New logical stream (#1, serial: $serial): type opus
Encoded with Lavf58.45.100
User comments section follows...
    encoder=opusenc from opus-tools 0.1.10
    encoder_options=--quiet --bitrate 96 --vbr
    pad=00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
    TeddyVersion=1.2.0-master+49d47dd
    TeddyFile=/Users/.../$id/500304E0
...

While this provides useful debugging information, one might want to avoid uploading/sharing such a file since information may be used to identify the tonie and the username.

Also, this part of the information appears to make the resulting files change their size, depending on the actual Teddy invocation. I consider this to be a POLA/POLS violation: decoding the same source file should result in identical output, independent of the input location in the filesystem.

Can addition of this information be made optional?

g3gg0 commented 1 year ago

privacy issue: grafik

For me personally it is very attractive to see the direct link to the originating tonie file name. However having the full path can be made optional.

steve8x8 commented 1 year ago

@g3gg0 I suppose the MessageBox only works in TeddyBench, not pure Teddy, as I never saw it (and there's no hint in the Teddy.exe -help output, hint, hint...). Perhaps I'd be fine with the last directory level and the filename proper ("basename" - that one is obvious anyway), as it usually wouldn't change when moving stuff around - but that still contains the complete identity of the tonie, doesn't it?

steve8x8 commented 1 year ago

opus2tonie seems to do the conversion without adding extra user comments, and it's rather OS-independent, so I will use that for now. (It doesn't have an idea of tonie names, track lists, etc. though.)