search

toniebox-reverse-engineering / teddycloud

teddyCloud is an open source server replacement for the Boxine Cloud
https://toniebox-reverse-engineering.github.io/docs/tools/teddycloud/
GNU General Public License v2.0
492 stars 36 forks source link

please update release tags to match common rules #264

Open P1tt187 opened 4 days ago

P1tt187 commented 4 days ago

Hi, I'm starting to use teddycloud. I version my containers in a git repository to update i use the renovate bot Sadly i noticed, that teddycloud does not follow common versioning rules

wrong: ghcr.io/toniebox-reverse-engineering/teddycloud:tc_v0.6.2_ubuntu

right: ghcr.io/toniebox-reverse-engineering/teddycloud:v0.6.2-ubuntu

You should remove tc_ prefix and use - instead of _

It would be nice if you can ensure that the release tags would match these rules

source: https://docs.renovatebot.com/modules/versioning/docker/

SciLor commented 3 days ago

It is not clear to me, why it should be wrong. The link doesn't provide details about that.

If it is really the case, I may add additional tags while keeping the old ones.

P1tt187 commented 3 days ago

Most Docker containers follows the semver schema if we take a look at the version of this project it is tc_v0.6.2_ubuntu this version starts with a prefix tc_ the prefix v is common on github, tools like renovate will respect that the suffix _ubuntu also violates the semver spec, you have to use a -

In this case tools like renovate cannot detect the version and i don't get update notifications. I could fix this for me with a renovate rule, but maybe i'm not the only one who does not want to use the latest tag.

source: https://semver.org/ an example from the semver doc can be found here: https://regex101.com/r/Ly7O1x/3/