toniebox-reverse-engineering / teddycloud_web

A better web interface for TeddyCloud
https://github.com/toniebox-reverse-engineering/teddycloud/
16 stars 7 forks source link

[Enhancement] New /web audio player can be minimized or is only displayed when playing #40

Closed oliver-koch closed 3 weeks ago

oliver-koch commented 4 months ago

[Enhancement] New /web audio player can be minimized or is only displayed when playing

It would be very nice, if the new /web audio player can be minimzed, or is displayed only, when playing a tonie.

ks61625 commented 4 months ago

Maybe the player can be moved into the header-nav-bar? If enough space, it can just stay there as it is, or just having a little player icon which popups the player (modal window) when clicked…?

henryk86 commented 4 months ago

You have to keep in mind, that the element must not be closed/reloaded during navigating through teddycloud to keep playing. as the header bar is quite full (especially on mobiles)… the side navigation bar has some spare place. But here: how to handle it on mobiles as there is no side navigation.

henryk86 commented 4 months ago

And before this should be implemented, the player should be finalized as it’s currently a in kind of paused dev version…

ks61625 commented 4 months ago

All true. Technicaly the real players dom element can stay where ever it has to stay (to not get refreshed etc), but it could be hidden. If so, there could be kind of remote controle by another (reloadable) „controler“ buttons. Just as idea to be independant from real players position vs controle button interface.

henryk86 commented 3 months ago

In next version, audioplay is hidden if no tonie is started to play.

oliver-koch commented 3 months ago

Very nice. Thank you very much!

henryk86 commented 3 months ago

The player can be also closed. Maybe there is some more optimisation for mobile in nearer future

henryk86 commented 3 months ago

The change is now in develop. Feel free to have a look

henryk86 commented 3 months ago

overworked again. can be minimized now:

https://github.com/toniebox-reverse-engineering/teddycloud_web/pull/74#issuecomment-2146861212

oliver-koch commented 3 months ago

Looks very nice. I will play with it, and give feedback here.

henryk86 commented 3 months ago

Merged in develop