toniebox-reverse-engineering / teddycloud_web

A better web interface for TeddyCloud
https://github.com/toniebox-reverse-engineering/teddycloud/
16 stars 7 forks source link

Please merge the Web development from teddycloud with Phoniebox #89

Closed Mannshoch closed 1 month ago

Mannshoch commented 1 month ago

Please merge the Web development from teddycloud with Phoniebox.

Detach the User experience from the hardware logic and work together.

See this ticket @ https://github.com/MiczFlor/RPi-Jukebox-RFID/discussions/2415

henryk86 commented 1 month ago

Why? 👹

Mannshoch commented 1 month ago

Synergies:

SciLor commented 1 month ago

I don't see synergies. The Toniebox is very special. The backend is optimized for that and needs very special handling for the audio tagging for example. There won't be much code shared.

g3gg0 commented 1 month ago

It could share fragments, but as already written, there would be a lot (too much) custom code for every project. Every line changed could cause regression test fails on the other.

Mannshoch commented 1 month ago

I don't see synergies. The Toniebox is very special. The backend is optimized for that and needs very special handling for the audio tagging for example. There won't be much code shared.

Not if the whole library works with the original uploaded files and the conversion to the toniebox file format happens the moment a download to the toniebox is needed.

Currently, the file - as far I assume - is converted as soon I uploaded the file to the teddycloud. But that way, what would happen if the toniebox replaces firmware and modify the way a mediafile have to look like.

The moment you have such boxes you need to manage two different file sets.

An other point may be, that you may not need to develop the library your self and could use one of the already available code. e.g.: https://medevel.com/music-and-audio-streaming/

SciLor commented 1 month ago

Not if the whole library works with the original uploaded files and the conversion to the toniebox file format happens the moment a download to the toniebox is needed.

This is not possible in a clean way. If you are converting on-the-fly, the file has to be cached afterwards and the box will redownload the file the next time, as there is a checksum at the beginning of the file.

And this is only one specific difference.