toniebox-reverse-engineering / tonies-json

Database of (all) Tonies and its metadata to identify it
35 stars 14 forks source link

Correcting some audio-id mixups and updating audio-ids #3

Closed n1ghty closed 10 months ago

n1ghty commented 10 months ago

There were some audio-ids assigned to the incorrect Tonie IDs. 10000309 -> 10000909 (audio-id already existed with missing information, but was assigned to both tonies) 10001693 -> 10000696 10001889 -> 10001989

I also added some unknown audio-ids.

I did not check for any further duplicates/mixups.

SciLor commented 10 months ago

Thank you for your corrections

n1ghty commented 10 months ago

when should confidence be set to 1?

SciLor commented 10 months ago

when should confidence be set to 1?

Confidence is set, when we can approve the audio-id with an automated process. So 0 is okay in this case.

n1ghty commented 10 months ago

The merge-conflict of 10000309 was incorrectly solved. You deleted the wrong audio-id (1632487122 which was just added with the rambudo changes instead of 1691659153)

SciLor commented 10 months ago

https://github.com/toniebox-reverse-engineering/tonies-json/blob/master/yaml/10000309.yaml

This one is the right way around now?