search

tonifisler / generator-styleguide

A Yeoman Generator for a Hologram Styleguide with Bootstrap Sass starting files.
MIT License
23 stars 6 forks source link

Missing jQuery #19

Closed Yago closed 9 years ago

Yago commented 9 years ago

Thanks for lighten the bower.json by removing useless package, but why jQuery ?!? I'm not his biggest fan, but I think you forget that all the Bootstrap widget need it... :wink:

tonifisler commented 9 years ago

jQuery is included into bootstrap-sass-official, no need to add it manually... Am I wrong? There is an issue when npm tries to install browser-sync though because apparently they did a rollback to 1.3.7 after 1.4.0...

Yago commented 9 years ago

Yep same issue with browser-sync.

You right about Bootstrap dependencies, I forgot :grin: But in my opinion controlling the version can be essential when you are using specific library.

tonifisler commented 9 years ago

You're right. I'll re-add jQuery and fix the BS version.